[PATCH 2/4 V2 RESEND] usb: dwc2: Make PHY optional

Stefan Wahren stefan.wahren at i2se.com
Fri Nov 13 09:02:10 PST 2015


From: John Youn <John.Youn at synopsys.com>

Fixes commit 09a75e857790
("usb: dwc2: refactor common low-level hw code to platform.c")

The above commit consolidated the low-level phy access into a common
location. This change introduced a check from the gadget requiring
that a PHY is specified. This requirement never existed on the host
side and broke some platforms when it was moved into platform.c.

The gadget doesn't require the PHY either so remove the check.

Reported-by: Stefan Wahren <info at lategoodbye.de>
Cc: Marek Szyprowski <m.szyprowski at samsung.com>
Signed-off-by: John Youn <johnyoun at synopsys.com>
Tested-by: Marek Szyprowski <m.szyprowski at samsung.com>
Fixes: 09a75e857790 ("usb: dwc2: refactor common low-level hw code to platform.c")
---
 drivers/usb/dwc2/platform.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 0e80087..702012a 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -228,11 +228,6 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg)
 			hsotg->phyif = GUSBCFG_PHYIF8;
 	}
 
-	if (!hsotg->phy && !hsotg->uphy && !hsotg->plat) {
-		dev_err(hsotg->dev, "no platform data or transceiver defined\n");
-		return -EPROBE_DEFER;
-	}
-
 	/* Clock */
 	hsotg->clk = devm_clk_get(hsotg->dev, "otg");
 	if (IS_ERR(hsotg->clk)) {
-- 
1.7.9.5




More information about the linux-rpi-kernel mailing list