[PATCH 11/11] ASoC: rockchip: Explain DAI link startup return value handling
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Thu Oct 15 21:09:46 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
Add comments explaining why the .startup() callbacks must return
0 on success to ensure the DAI link is correctly marked as started
and prevent future changes from reintroducing the issue.
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
sound/soc/rockchip/rk3399_gru_sound.c | 5 +++++
sound/soc/rockchip/rockchip_max98090.c | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c
index 0ec80a4b8c59..d4a0daabfb42 100644
--- a/sound/soc/rockchip/rk3399_gru_sound.c
+++ b/sound/soc/rockchip/rk3399_gru_sound.c
@@ -266,6 +266,11 @@ static int rockchip_sound_startup(struct snd_pcm_substream *substream)
if (ret < 0)
return ret;
+ /*
+ * ASoC only marks the DAI link as started when .startup() returns 0.
+ * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly
+ * return 0 to ensure the DAI link is correctly marked as started.
+ */
return 0;
}
diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c
index d54c36682415..de392b420ebd 100644
--- a/sound/soc/rockchip/rockchip_max98090.c
+++ b/sound/soc/rockchip/rockchip_max98090.c
@@ -202,6 +202,11 @@ static int rk_aif1_startup(struct snd_pcm_substream *substream)
if (ret < 0)
return ret;
+ /*
+ * ASoC only marks the DAI link as started when .startup() returns 0.
+ * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly
+ * return 0 to ensure the DAI link is correctly marked as started.
+ */
return 0;
}
--
2.43.0
More information about the Linux-rockchip
mailing list