[PATCH 07/11] ASoC: renesas: msiof: Explain component open return value handling
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Thu Oct 15 21:09:42 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
Add a comment explaining why .open() must return 0 on success
to ensure the component is correctly marked as opened and
prevent future changes from reintroducing the issue.
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
sound/soc/renesas/fsi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c
index 88618e4b052d..74e2ea002fbb 100644
--- a/sound/soc/renesas/fsi.c
+++ b/sound/soc/renesas/fsi.c
@@ -1820,6 +1820,11 @@ static int fsi_pcm_open(struct snd_soc_component *component,
if (ret < 0)
return ret;
+ /*
+ * ASoC only marks the component as opened when .open() returns 0.
+ * Since snd_pcm_hw_constraint_integer() may return 1, explicitly
+ * return 0 to ensure the component is correctly marked as opened.
+ */
return 0;
}
--
2.43.0
More information about the Linux-rockchip
mailing list