[PATCH 02/11] ASoC: apple: Explain DAI startup return value handling
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Thu Oct 15 21:09:37 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
Add a comment explaining why .startup() must return 0 on success
to ensure the DAI is correctly marked as started and prevent
future changes from reintroducing the issue.
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
sound/soc/apple/mca.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c
index 3585432ad49b..26022a42a95e 100644
--- a/sound/soc/apple/mca.c
+++ b/sound/soc/apple/mca.c
@@ -535,6 +535,11 @@ static int mca_fe_startup(struct snd_pcm_substream *substream,
if (ret < 0)
return ret;
+ /*
+ * ASoC only marks the DAI as started when .startup() returns 0.
+ * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly
+ * return 0 to ensure the DAI is correctly marked as started.
+ */
return 0;
}
--
2.43.0
More information about the Linux-rockchip
mailing list