[PATCH v2 24/25] ASoC: rockchip: rk3399_gru_sound: Mark the link as started on success
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Wed Oct 14 18:43:23 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
snd_pcm_hw_constraint_minmax() may return 1, which is then returned
from rockchip_sound_startup(). ASoC only marks the DAI link as started
when .startup() returns 0.
This currently has no functional impact, as there is no .shutdown()
callback in the relevant snd_soc_ops. Still, return 0 explicitly on
success to match what ASoC expects and ensure the DAI link is correctly
marked as started.
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
sound/soc/rockchip/rk3399_gru_sound.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c
index 04e7bed8275d..d4a0daabfb42 100644
--- a/sound/soc/rockchip/rk3399_gru_sound.c
+++ b/sound/soc/rockchip/rk3399_gru_sound.c
@@ -258,10 +258,20 @@ static int rockchip_sound_dmic_hw_params(struct snd_pcm_substream *substream,
static int rockchip_sound_startup(struct snd_pcm_substream *substream)
{
struct snd_pcm_runtime *runtime = substream->runtime;
+ int ret;
runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
- return snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE,
- 8000, 96000);
+ ret = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE,
+ 8000, 96000);
+ if (ret < 0)
+ return ret;
+
+ /*
+ * ASoC only marks the DAI link as started when .startup() returns 0.
+ * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly
+ * return 0 to ensure the DAI link is correctly marked as started.
+ */
+ return 0;
}
static const struct snd_soc_ops rockchip_sound_max98357a_ops = {
--
2.43.0
More information about the Linux-rockchip
mailing list