[PATCH 00/24] ASoC: Fix constraint return value handling

[Mukunda,Vijendar]

On 10/8/26 16:08, phucduc.bui at gmail.com wrote:
> [You don't often get email from phucduc.bui at gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: bui duc phuc <phucduc.bui at gmail.com>
>
> Hi all,
>
> snd_pcm_hw_constraint_minmax() and snd_pcm_hw_constraint_integer()
> may return positive values on success. However, ASoC only marks the
> DAI, link, or component as started or opened when the corresponding
> callback returns 0.
>
> This series fixes affected ASoC drivers to return 0 on success and
> properly handle rollback paths.
>
> Found by manual code inspection.
For AMD patches:

Reviewed-By: Vijendar Mukunda <Vijendar.Mukunda at amd.com>
>
> Compile-tested only.
>
> Best regards,
> Phuc
>
> bui duc phuc (24):
>    ASoC: amd: acp: Fix .close() being skipped on rollback
>    ASoC: amd: ps: Fix acp63_pdm_dma_close() being skipped on rollback
>    ASoC: amd: ps: Fix acp63_sdw_dma_close() being skipped on rollback
>    ASoC: amd: raven: Fix acp3x_dma_close() being skipped on rollback
>    ASoC: amd: renoir: Fix acp_pdm_dma_close() being skipped on rollback
>    ASoC: amd: vangogh: Fix acp5x_dma_close() being skipped on rollback
>    ASoC: amd: yc: Fix acp6x_pdm_dma_close() being skipped on rollback
>    ASoC: apple: mca: Ensure the DAI is marked as started on success
>    ASoC: atmel: atmel-pcm-pdc: Fix atmel_pcm_close() being skipped on
>      rollback
>    ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success
>    ASoC: codecs: nau8325: Ensure the DAI is marked as started on success
>    ASoC: codecs: nau8540: Ensure the DAI is marked as started on success
>    ASoC: codecs: nau8821: Ensure the DAI is marked as started on success
>    ASoC: codecs: nau8824: Ensure the DAI is marked as started on success
>    ASoC: codecs: nau8825: Ensure the DAI is marked as started on success
>    ASoC: codecs: wm8580: Ensure the DAI is marked as started on success
>    ASoC: codecs: wm8782: Ensure the DAI is marked as started on success
>    ASoC: imx-pcm-rpmsg: Fix imx_rpmsg_pcm_close() being skipped on
>      rollback
>    ASoC: intel: atom: Fix .shutdown() being skipped on rollback
>    ASoC: renesas: fsi: Ensure the component is marked as opened on
>      success
>    ASoC: renesas: msiof: Fix msiof_close() being skipped on rollback
>    ASoC: renesas: rz-ssi: Ensure the component is marked as opened on
>      success
>    ASoC: rockchip: rk3399_gru_sound: Mark the link as started on success
>    ASoC: rockchip: rockchip_max98090: Mark the link as started on success
>
>   sound/soc/amd/acp/acp-platform.c             |  2 +-
>   sound/soc/amd/ps/ps-pdm-dma.c                |  2 +-
>   sound/soc/amd/ps/ps-sdw-dma.c                |  2 +-
>   sound/soc/amd/raven/acp3x-pcm-dma.c          |  2 +-
>   sound/soc/amd/renoir/acp3x-pdm-dma.c         |  2 +-
>   sound/soc/amd/vangogh/acp5x-pcm-dma.c        |  2 +-
>   sound/soc/amd/yc/acp6x-pdm-dma.c             |  2 +-
>   sound/soc/apple/mca.c                        | 11 ++++++++---
>   sound/soc/atmel/atmel-pcm-pdc.c              |  2 ++
>   sound/soc/codecs/cs42l42.c                   | 11 ++++++++---
>   sound/soc/codecs/nau8325.c                   | 11 ++++++++---
>   sound/soc/codecs/nau8540.c                   | 11 ++++++++---
>   sound/soc/codecs/nau8821.c                   | 11 ++++++++---
>   sound/soc/codecs/nau8824.c                   | 11 ++++++++---
>   sound/soc/codecs/nau8825.c                   | 11 ++++++++---
>   sound/soc/codecs/wm8580.c                    | 10 ++++++++--
>   sound/soc/codecs/wm8782.c                    |  7 ++++++-
>   sound/soc/fsl/imx-pcm-rpmsg.c                |  2 +-
>   sound/soc/intel/atom/sst-mfld-platform-pcm.c |  2 +-
>   sound/soc/renesas/fsi.c                      |  6 ++++--
>   sound/soc/renesas/rcar/msiof.c               |  6 ++++--
>   sound/soc/renesas/rz-ssi.c                   | 18 +++++++++++++++---
>   sound/soc/rockchip/rk3399_gru_sound.c        |  9 +++++++--
>   sound/soc/rockchip/rockchip_max98090.c       | 10 ++++++++--
>   24 files changed, 119 insertions(+), 44 deletions(-)
>
> --
> 2.43.0