[PATCH 21/24] ASoC: renesas: msiof: Fix msiof_close() being skipped on rollback
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Mon Oct 12 22:49:06 PDT 2026
Hi Bui
> I'll add a comment to explain why the return value must be normalized to 0
> in the affected drivers.
Thanks
> For MSIOF, I noticed that snd_dmaengine_pcm_open() already calls
> snd_pcm_hw_constraint_integer() for SNDRV_PCM_HW_PARAM_PERIODS,
> so the call in msiof_open() seems redundant.
>
> Since the first call succeeds, the second call should return 0.
> Would removing the redundant call be acceptable?
Nice cache, yes please.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the Linux-rockchip
mailing list