[PATCH 1/3] ASoC: dt-bindings: rockchip-spdif: Correct SPDIF clock descriptions

Krzysztof Kozlowski krzk at kernel.org
Sat May 30 03:44:46 PDT 2026


On Fri, May 22, 2026 at 05:03:16PM +0700, phucduc.bui at gmail.com wrote:
> From: bui duc phuc <phucduc.bui at gmail.com>
> 
> The clock descriptions are currently swapped relative to the
> clock names used by the driver.

Why would order of clock names in the driver matter here? I do not
understand that explanation.

> 
> Update the binding descriptions to match the actual clock
> usage, where 'mclk' is the controller clock and 'hclk' is
> the bus clock.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
> ---
>  Documentation/devicetree/bindings/sound/rockchip-spdif.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml b/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml
> index 502907dd28b3..b174d7498029 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml
> @@ -45,8 +45,8 @@ properties:
>  
>    clocks:
>      items:
> -      - description: clock for SPDIF bus
>        - description: clock for SPDIF controller
> +      - description: clock for SPDIF bus

So example is wrong?

What about all the users?

Best regards,
Krzysztof




More information about the Linux-rockchip mailing list