[PATCH v2 4/5] phy: rockchip: inno-usb2: Add clkout_ctl_phy support
Heiko Stuebner
heiko at sntech.de
Wed May 27 03:46:29 PDT 2026
Hi Vinod,
Am Donnerstag, 14. Mai 2026, 18:17:37 Mitteleuropäische Sommerzeit schrieb Vinod Koul:
> On 05-05-26, 19:04, Heiko Stuebner wrote:
> > From: Jonas Karlman <jonas at kwiboo.se>
> >
> > The 480m clk is controlled using regs in the PHY address space and not
> > in the USB GRF address space on e.g. RK3528 and RK3506.
> >
> > Add a clkout_ctl_phy usb2phy_reg to handle enable/disable of the 480m
> > clk on these SoCs.
> >
> > Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
> > Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> > ---
> > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 47 +++++++++++++++----
> > 1 file changed, 38 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> > index 7cec45192393..d8879fcd4291 100644
> > --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> > +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> > @@ -179,6 +179,7 @@ struct rockchip_usb2phy_cfg {
> > unsigned int num_ports;
> > int (*phy_tuning)(struct rockchip_usb2phy *rphy);
> > struct usb2phy_reg clkout_ctl;
> > + struct usb2phy_reg clkout_ctl_phy;
>
> This gives a kernel-doc warning. I have applied please send fix for this
Just if someone reads that in the future, I sent a fix for that last week in:
https://lore.kernel.org/lkml/20260520102859.1357411-1-heiko@sntech.de/
Heiko
More information about the Linux-rockchip
mailing list