[PATCH v3 0/6] drm/rockchip: Fix error handling and resource leaks in Rockchip DRM drivers
Jiaqi
shijiaqi_develop at 163.com
Sat May 9 01:33:25 PDT 2026
This is v3 of the patch series.
Changes in v3:
- Fixed Content-Transfer-Encoding from base64 to 7bit (was
incorrectly using Python MIMEText with charset=utf-8)
- Fixed Message-ID domain to use sender email domain
- Fixed patch subject format: [PATCH N/6 v2] to [PATCH v3 N/6]
Changes in v2:
- Patch 3/6: Removed incorrect devm_free_irq() call in error path.
The IRQ registered via devm_request_irq() is managed by devres
and must NOT be manually freed.
- Patch 5/6: Fixed trailing format issue that caused checkpatch ERROR.
This patch series fixes 6 bugs in the Rockchip DRM driver subsystem,
identified through static code analysis and confirmed by technical review.
Summary of fixes:
Patch 1/6 (Critical): Fix of_node reference leak in
rockchip_drm_encoder_set_crtc_endpoint_id(). Both success and error
paths leaked references acquired via of_graph helpers.
Patch 2/6 (Critical): Fix dangling crtc->state in vop2_crtc_reset().
kzalloc() failure left crtc->state as a use-after-free pointer.
Patch 3/6 (High): Fix vop2_create_crtcs() error path cleanup in
vop2_bind(). Failures returned directly without calling
vop2_destroy_crtcs(), leaking of_node references. (v2: fixed
double-free by removing manual devm_free_irq())
Patch 4/6 (High): Fix vmap address caching in
rockchip_gem_prime_vmap(). New vmap() results were not saved to
rk_obj->kvaddr, causing repeated mappings and potential leaks.
Patch 5/6 (High): Fix leaked vblank event in
vop_crtc_atomic_disable(). Pending vop->event was warned but never
sent, causing userspace hangs and vblank reference leaks. (v2:
fixed checkpatch format error)
Patch 6/6 (Medium): Check return value of cdn_dp_grf_write() in
cdn_dp_enable_phy() error path. Ignored return value could leave
GRF registers in an inconsistent state.
All patches have been verified against checkpatch.pl --strict.
Signed-off-by: Jiaqi <shijiaqi_develop at 163.com>
More information about the Linux-rockchip
mailing list