[PATCH 08/17] spi: rockchip-sfc: Use helper function devm_clk_get_enabled()
Pei Xiao
xiaopei01 at kylinos.cn
Thu Mar 12 02:29:00 PDT 2026
devm_clk_get() and clk_prepare_enable() can now be replaced by
devm_clk_get_enabled() when driver enables the clocks. Moreover, it is no
longer necessary to unprepare and disable the clocks explicitly.
Simplify code.
Signed-off-by: Pei Xiao <xiaopei01 at kylinos.cn>
---
drivers/spi/spi-rockchip-sfc.c | 20 ++------------------
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
index 174995042f53..ef6956f2c918 100644
--- a/drivers/spi/spi-rockchip-sfc.c
+++ b/drivers/spi/spi-rockchip-sfc.c
@@ -635,13 +635,13 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
return PTR_ERR(sfc->regbase);
if (!has_acpi_companion(&pdev->dev))
- sfc->clk = devm_clk_get(&pdev->dev, "clk_sfc");
+ sfc->clk = devm_clk_get_enabled(&pdev->dev, "clk_sfc");
if (IS_ERR(sfc->clk))
return dev_err_probe(&pdev->dev, PTR_ERR(sfc->clk),
"Failed to get sfc interface clk\n");
if (!has_acpi_companion(&pdev->dev))
- sfc->hclk = devm_clk_get(&pdev->dev, "hclk_sfc");
+ sfc->hclk = devm_clk_get_enabled(&pdev->dev, "hclk_sfc");
if (IS_ERR(sfc->hclk))
return dev_err_probe(&pdev->dev, PTR_ERR(sfc->hclk),
"Failed to get sfc ahb clk\n");
@@ -657,18 +657,6 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
sfc->use_dma = !of_property_read_bool(sfc->dev->of_node, "rockchip,sfc-no-dma");
- ret = clk_prepare_enable(sfc->hclk);
- if (ret) {
- dev_err(&pdev->dev, "Failed to enable ahb clk\n");
- goto err_hclk;
- }
-
- ret = clk_prepare_enable(sfc->clk);
- if (ret) {
- dev_err(&pdev->dev, "Failed to enable interface clk\n");
- goto err_clk;
- }
-
/* Find the irq */
ret = platform_get_irq(pdev, 0);
if (ret < 0)
@@ -730,10 +718,6 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
pm_runtime_set_suspended(dev);
pm_runtime_dont_use_autosuspend(dev);
err_irq:
- clk_disable_unprepare(sfc->clk);
-err_clk:
- clk_disable_unprepare(sfc->hclk);
-err_hclk:
return ret;
}
--
2.25.1
More information about the Linux-rockchip
mailing list