[Intel-wired-lan] [PATCH 50/61] iommu: Prefer IS_ERR_OR_NULL over manual NULL check

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf
> Of Philipp Hahn
> Sent: Tuesday, March 10, 2026 12:49 PM
> To: amd-gfx at lists.freedesktop.org; apparmor at lists.ubuntu.com;
> bpf at vger.kernel.org; ceph-devel at vger.kernel.org; cocci at inria.fr; dm-
> devel at lists.linux.dev; dri-devel at lists.freedesktop.org;
> gfs2 at lists.linux.dev; intel-gfx at lists.freedesktop.org; intel-wired-
> lan at lists.osuosl.org; iommu at lists.linux.dev; kvm at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-block at vger.kernel.org;
> linux-bluetooth at vger.kernel.org; linux-btrfs at vger.kernel.org; linux-
> cifs at vger.kernel.org; linux-clk at vger.kernel.org; linux-
> erofs at lists.ozlabs.org; linux-ext4 at vger.kernel.org; linux-
> fsdevel at vger.kernel.org; linux-gpio at vger.kernel.org; linux-
> hyperv at vger.kernel.org; linux-input at vger.kernel.org; linux-
> kernel at vger.kernel.org; linux-leds at vger.kernel.org; linux-
> media at vger.kernel.org; linux-mips at vger.kernel.org; linux-mm at kvack.org;
> linux-modules at vger.kernel.org; linux-mtd at lists.infradead.org; linux-
> nfs at vger.kernel.org; linux-omap at vger.kernel.org; linux-
> phy at lists.infradead.org; linux-pm at vger.kernel.org; linux-
> rockchip at lists.infradead.org; linux-s390 at vger.kernel.org; linux-
> scsi at vger.kernel.org; linux-sctp at vger.kernel.org; linux-security-
> module at vger.kernel.org; linux-sh at vger.kernel.org; linux-
> sound at vger.kernel.org; linux-stm32 at st-md-mailman.stormreply.com;
> linux-trace-kernel at vger.kernel.org; linux-usb at vger.kernel.org; linux-
> wireless at vger.kernel.org; netdev at vger.kernel.org;
> ntfs3 at lists.linux.dev; samba-technical at lists.samba.org; sched-
> ext at lists.linux.dev; target-devel at vger.kernel.org; tipc-
> discussion at lists.sourceforge.net; v9fs at lists.linux.dev; Philipp Hahn
> <phahn-oss at avm.de>
> Cc: Joerg Roedel <joro at 8bytes.org>; Will Deacon <will at kernel.org>;
> Robin Murphy <robin.murphy at arm.com>
> Subject: [Intel-wired-lan] [PATCH 50/61] iommu: Prefer IS_ERR_OR_NULL
> over manual NULL check
> 
> Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL
> check.
> 
> Change generated with coccinelle.
> 
> To: Joerg Roedel <joro at 8bytes.org>
> To: Will Deacon <will at kernel.org>
> To: Robin Murphy <robin.murphy at arm.com>
> Cc: iommu at lists.linux.dev
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Philipp Hahn <phahn-oss at avm.de>
> ---
>  drivers/iommu/omap-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index
> 8231d7d6bb6a9202025643639a6b28e6faa84659..500a42b57a997696ff37c76f028a
> 717ab71d01f9 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -881,7 +881,7 @@ static int omap_iommu_attach(struct omap_iommu
> *obj, u32 *iopgd)
>   **/
>  static void omap_iommu_detach(struct omap_iommu *obj)  {
> -	if (!obj || IS_ERR(obj))
> +	if (IS_ERR_OR_NULL(obj))
>  		return;
> 
>  	spin_lock(&obj->iommu_lock);
> 
> --
> 2.43.0

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>