[Intel-wired-lan] [PATCH 49/61] media: Prefer IS_ERR_OR_NULL over manual NULL check
Loktionov, Aleksandr
aleksandr.loktionov at intel.com
Wed Mar 11 02:25:58 PDT 2026
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf
> Of Philipp Hahn
> Sent: Tuesday, March 10, 2026 12:49 PM
> To: amd-gfx at lists.freedesktop.org; apparmor at lists.ubuntu.com;
> bpf at vger.kernel.org; ceph-devel at vger.kernel.org; cocci at inria.fr; dm-
> devel at lists.linux.dev; dri-devel at lists.freedesktop.org;
> gfs2 at lists.linux.dev; intel-gfx at lists.freedesktop.org; intel-wired-
> lan at lists.osuosl.org; iommu at lists.linux.dev; kvm at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-block at vger.kernel.org;
> linux-bluetooth at vger.kernel.org; linux-btrfs at vger.kernel.org; linux-
> cifs at vger.kernel.org; linux-clk at vger.kernel.org; linux-
> erofs at lists.ozlabs.org; linux-ext4 at vger.kernel.org; linux-
> fsdevel at vger.kernel.org; linux-gpio at vger.kernel.org; linux-
> hyperv at vger.kernel.org; linux-input at vger.kernel.org; linux-
> kernel at vger.kernel.org; linux-leds at vger.kernel.org; linux-
> media at vger.kernel.org; linux-mips at vger.kernel.org; linux-mm at kvack.org;
> linux-modules at vger.kernel.org; linux-mtd at lists.infradead.org; linux-
> nfs at vger.kernel.org; linux-omap at vger.kernel.org; linux-
> phy at lists.infradead.org; linux-pm at vger.kernel.org; linux-
> rockchip at lists.infradead.org; linux-s390 at vger.kernel.org; linux-
> scsi at vger.kernel.org; linux-sctp at vger.kernel.org; linux-security-
> module at vger.kernel.org; linux-sh at vger.kernel.org; linux-
> sound at vger.kernel.org; linux-stm32 at st-md-mailman.stormreply.com;
> linux-trace-kernel at vger.kernel.org; linux-usb at vger.kernel.org; linux-
> wireless at vger.kernel.org; netdev at vger.kernel.org;
> ntfs3 at lists.linux.dev; samba-technical at lists.samba.org; sched-
> ext at lists.linux.dev; target-devel at vger.kernel.org; tipc-
> discussion at lists.sourceforge.net; v9fs at lists.linux.dev; Philipp Hahn
> <phahn-oss at avm.de>
> Cc: Shuah Khan <skhan at linuxfoundation.org>; Kieran Bingham
> <kieran.bingham at ideasonboard.com>; Mauro Carvalho Chehab
> <mchehab at kernel.org>
> Subject: [Intel-wired-lan] [PATCH 49/61] media: Prefer IS_ERR_OR_NULL
> over manual NULL check
>
> Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL
> check.
>
> Change generated with coccinelle.
>
> To: Shuah Khan <skhan at linuxfoundation.org>
> To: Kieran Bingham <kieran.bingham at ideasonboard.com>
> To: Mauro Carvalho Chehab <mchehab at kernel.org>
> Cc: linux-media at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Philipp Hahn <phahn-oss at avm.de>
> ---
> drivers/media/test-drivers/vimc/vimc-streamer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/test-drivers/vimc/vimc-streamer.c
> b/drivers/media/test-drivers/vimc/vimc-streamer.c
> index
> 15d863f97cbf96b7ca7fbf3d7b6b6ec39fcc8ae3..da5aca50bcb4990c06f28e5a883e
> b398606991e9 100644
> --- a/drivers/media/test-drivers/vimc/vimc-streamer.c
> +++ b/drivers/media/test-drivers/vimc/vimc-streamer.c
> @@ -167,7 +167,7 @@ static int vimc_streamer_thread(void *data)
> for (i = stream->pipe_size - 1; i >= 0; i--) {
> frame = stream->ved_pipeline[i]->process_frame(
> stream->ved_pipeline[i], frame);
> - if (!frame || IS_ERR(frame))
> + if (IS_ERR_OR_NULL(frame))
> break;
> }
> //wait for 60hz
>
> --
> 2.43.0
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
More information about the Linux-rockchip
mailing list