[PATCH v3 phy-next 17/24] media: sunxi: a83-mips-csi2: include PHY provider header
Chen-Yu Tsai
wens at kernel.org
Mon Mar 9 19:45:01 PDT 2026
On Tue, Mar 10, 2026 at 3:10 AM Vladimir Oltean <vladimir.oltean at nxp.com> wrote:
>
> The introduction commit 576d196c522b ("media: sunxi: Add support for the
> A83T MIPI CSI-2 controller") says:
>
> This implementation splits the protocol and D-PHY registers and
> uses the PHY framework internally. The D-PHY is not registered as a
> standalone PHY driver since it cannot be used with any other
> controller.
>
> However, this does not matter, and is not the only instance of tight PHY
> provider <-> consumer pairing. According to Vinod Koul, having PHY
> provider drivers outside of drivers/phy/ is discouraged, although it
> would be difficult for me to address a proper movement here.
>
> So just include the private provider API header from drivers/phy/ and
> leave a FIXME in place.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean at nxp.com>
Acked-by: Chen-Yu Tsai <wens at kernel.org>
> ---
> Cc: Mauro Carvalho Chehab <mchehab at kernel.org>
> Cc: Chen-Yu Tsai <wens at kernel.org>
> Cc: Jernej Skrabec <jernej.skrabec at gmail.com>
> Cc: Samuel Holland <samuel at sholland.org>
>
> v1->v3: none
> ---
> .../media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_dphy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_dphy.c b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_dphy.c
> index 24bbcc85013d..1143feeb4fcb 100644
> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_dphy.c
> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_dphy.c
> @@ -4,9 +4,9 @@
> * Author: Paul Kocialkowski <paul.kocialkowski at bootlin.com>
> */
>
> -#include <linux/phy/phy.h>
> #include <linux/regmap.h>
>
> +#include "../../../../phy/phy-provider.h" /* FIXME */
> #include "sun8i_a83t_dphy.h"
> #include "sun8i_a83t_mipi_csi2.h"
>
> --
> 2.43.0
>
More information about the Linux-rockchip
mailing list