[PATCH v2] spi: rockchip-sfc: Fix double-free in remove() callback

Mark Brown broonie at kernel.org
Mon Mar 9 15:37:11 PDT 2026


On Tue, 10 Mar 2026 02:01:34 +0800, Felix Gu wrote:
> The driver uses devm_spi_register_controller() for registration, which
> automatically unregisters the controller via devm cleanup when the
> device is removed. The manual call to spi_unregister_controller() in
> the remove() callback can lead to a double-free.
> 
> And to make sure controller is unregistered before DMA buffer is
> unmapped, switch to use spi_register_controller() in probe().
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: rockchip-sfc: Fix double-free in remove() callback
      commit: 111e2863372c322e836e0c896f6dd9cf4ee08c71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark




More information about the Linux-rockchip mailing list