[PATCH 1/3] dt-bindings: power: rockchip: Add pm_shaping support
Krzysztof Kozlowski
krzk at kernel.org
Sat Mar 7 07:17:00 PST 2026
On Fri, Mar 06, 2026 at 03:40:30PM +0800, Shawn Lin wrote:
> pm_shaping is introduced for some platforms to throttle the outstanding
> burst requests of each IP to prevent bus monopolization. Add a discription
> of it.
Isn't that interconnects?
Also which platforms? We don't add it for your downstream code. Why
there is no property restriction per variant in the binding?
>
> Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
> ---
>
> .../devicetree/bindings/power/rockchip,power-controller.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index b41db57..4af6c30 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -147,6 +147,14 @@ $defs:
> A number of phandles to qos blocks which need to be saved and restored
> while power domain switches state.
>
> + pm_shaping:
Read DTS coding style. Build your code with W=2 so you will see here
warnings.
Also, read writing bindings or any docs for beginners. Missing prefix.
> + $ref: /schemas/types.yaml#/definitions/phandle-array
so phandle? Or array? Decide...
> + items:
> + maxItems: 1
So how many items?
> + description: |
Drop |
> + A number of phandles to shaping blocks which need to be saved and restored
> + while power domain switches state.
Wrap code according to Linux coding style.
Best regards,
Krzysztof
More information about the Linux-rockchip
mailing list