[PATCH 0/3] Add shaping support for Rockchip platforms

[Shawn Lin]

在 2026/03/06 星期五 18:43, Heiko Stuebner 写道:
> Hi Shawn,
> 
> Am Freitag, 6. März 2026, 08:40:29 Mitteleuropäische Normalzeit schrieb Shawn Lin:
>> pm_shaping is introduced for some platforms to throttle the outstanding
>> burst requests of each IP to prevent bus monopolization. It should be
>> saved and restored along with the on/off of pmdomain, the same as pm_qos.
>> This patchset adds support for it.
> 
> Can we get some more descriptive naming for the feature please?
> In the commit messages, dt-binding and also node-names in the soc dtsi.
> Because anyone glancing at either the binding or dtsi will not understand
> what this is, and would even need to consult the git history for any
> explanation.
> 
> The full interconnect is not part of the TRM I have, but the bits and
> pieces in other parts of the TRM speak of traffic-shaping.
> 

traffic-shaping looks good to me.

> So for the node I'd go for:
> 	shaping_vepu1: traffic-shaping at 27f06088
> 
> and in the binding something like:
> 	rockchip,pm-traffic-shaping = <....>
> 
> I think the whole pm_qos thing is an oversight of the past, because:
> 
> - properties should use dashes "-" not underscores
> - the property name is Rockchip specific, so should likely get a prefix
> 

Yeah, pm_qos is for sure an oversight of the past, I shouldn't would
expect to follow the wrong convention here. Will update v2 later.

Thanks.

> 
> Heiko
> 
> 
> 
>