[PATCH 1/2] [RESEND] media: rkvdec: reduce excessive stack usage in assemble_hw_pps()
Arnd Bergmann
arnd at arndb.de
Thu Mar 5 09:10:06 PST 2026
On Thu, Mar 5, 2026, at 17:37, Nicolas Dufresne wrote:
>
> Le jeudi 05 mars 2026 à 16:26 +0100, Arnd Bergmann a écrit :
>> From: Arnd Bergmann <arnd at arndb.de>
>>
>> The rkvdec_pps had a large set of bitfields, all of which
>> as misaligned. This causes clang-21 and likely other versions to
>> produce absolutely awful object code and a warning about very
>> large stack usage, on targets without unaligned access:
>
> I'm a bit surprised you felt the need for resend. Perhaps you can help us
> understand what made you think your patch wasn't being processed ?
I updated the second patch today after I found a corner case that
wasn't addressed by the first version. As I had sent both as a series
a month ago, and neither was in linux-next yet, it seemed more helpful
to send an updated series rather than replace only one of the two.
> My PR:
> https://patchwork.linuxtv.org/project/linux-media/patch/2074ba5a5d05e239f432d176eb051105f7e692f9.camel@collabora.com/
>
> And Hans/Mauro did logistic on the #linux-maint IRC channel this morning. I
> believe I've marked all the relevant patches on patchwork our of "New" state and
> you have my Rb. What else would help you ?
That's fine then, I did not mean to seem impatient. I assume
the original patches will be in linux-next then, and [v2 2/2]
will conflict. I'll let you review that one first, but can
send a rebased version if you think we should merge it on top.
Arnd
More information about the Linux-rockchip
mailing list