[PATCH 2/2] arm64: dts: rockchip: Add Orange Pi 5 Pro board support

[Dennis Gilmore]

On Tue, Mar 3, 2026 at 9:45 PM Jimmy Hon <honyuenkwun at gmail.com> wrote:
>
> On Tue, Mar 3, 2026 at 1:43 PM Dennis Gilmore <dennis at ausil.us> wrote:
> >
> > On Mon, Mar 2, 2026 at 11:57 PM Jimmy Hon <honyuenkwun at gmail.com> wrote:
> > >
> > > Hi Dennis,
> > >
> > > Some curiosities below,
> > >
> > > On Sat, Feb 28, 2026 at 2:54 PM <dennis at ausil.us> wrote:
> > > <snip>
> > > > +
> > > > +       /* Pro uses gpio-leds instead; pwm0 LED is not wired up */
> > > > +       /delete-node/ pwm-leds;
> > > <snip>
> > > > +
> > > > +       gpio-leds {
> > > > +               compatible = "gpio-leds";
> > > > +               pinctrl-names = "default";
> > > > +               pinctrl-0 = <&leds_rgb>;
> > > > +
> > > > +               blue-led {
> > > > +                       color = <LED_COLOR_ID_BLUE>;
> > > > +                       function = LED_FUNCTION_STATUS;
> > > > +                       gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_HIGH>;
> > > How come you decided gpio-leds instead of pwm-leds for this? GPIO1 C6
> > > is muxed with PWM15_IR_M2
> >
> > the downstream dts uses gpio-leds  the GPIO comes from the schematic
> It should be fine to upgrade to pwm-leds when adding into mainline.
> The Orange 5 Plus did.
> In the downstream DTS, they used gpio-led for the green led
> https://github.com/orangepi-xunlong/linux-orangepi/blob/232ed4b97b65da2b7b647c4e3c496f8594b9f3f1/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts#L31-L36
> But in the mainline kernel, it was converted to use pwm-led.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts?id=236d225e1ee72a28aa7c2b1e39894e4390bbf51c
>
> Jimmy

Is there a reason the blue led was not converted from GPIO to PWM, and
only the green led was?

Dennis