[PATCH V13 8/9] iio: imu: inv_icm42607: Add Gyroscope to icm42607
Chris Morgan
macromorgan at hotmail.com
Tue Jun 23 09:38:06 PDT 2026
On Tue, Jun 23, 2026 at 04:15:27PM +0100, Jonathan Cameron wrote:
> On Tue, 23 Jun 2026 09:52:36 +0300
> Andy Shevchenko <andriy.shevchenko at intel.com> wrote:
>
> > On Wed, Jun 17, 2026 at 04:10:49PM -0500, Chris Morgan wrote:
> > > On Tue, Jun 16, 2026 at 01:13:03PM +0300, Andy Shevchenko wrote:
> > > > On Mon, Jun 15, 2026 at 12:25:51PM -0500, Chris Morgan wrote:
> >
> > ...
> >
> > > > Can be some of the code deduplicated between gyro and accel?
> > >
> > > Probably a fair amount, but the deduplication will likely need to be
> > > undone somewhat if we get buffer, WoM or apex support added back
> > > (I don't have any devices with such functionality, so if anyone will
> > > do it then it won't be me). I can refactor more if you want, or we
> > > can keep it split like this to make it easy if someone else wants to
> > > tackle the buffers/IRQs stuff later? Your call.
> >
> > Just asking. Jonathan, David, Nuno, what's your opinion on this?
> > Personal opinion is to avoid solving the issues that do not exist.
> > If you are not committing into those features, let's not prepare
> > driver for them right now.
> >
> Agreed. My only exception to this is normally when someone tells
> me they have the code and plan to post a follow up set very shortly.
> Then I get a bit more relaxed as they chances of 'preparing' for the
> future being relevant become much higher!
>
> Jonathan
Okay, I'll refactor a bit more then and resubmit in another week or
two.
Thanks,
Chris
More information about the Linux-rockchip
mailing list