[PATCH 2/3] can: rockchip: add RK3588 CAN-FD support

[Cunhao Lu]

Hi Heiko,

thanks for the guidance, and thanks for leaving this to me. :-)

> I don't think we need two people working on this and you did the better
> investigation into the differences, so you should get the credit :-)
>
> So I guess my preference would be to:
> - pick up the erratum 6 into your patch
> - add my haikou patch to the series - that way we also get a user
> - handle Krzysztof's comment from
>   https://lore.kernel.org/linux-rockchip/20260701-sensible-cryptic-ocelot-58035b@quoll/
>
>   as both our bindings have the same structure, so I guess it should be
>
>     oneOf:
>        - enum:
>              rockchip,rk3568v2-canfd
>              rockchip,rk3588v2-canfd
>        - items:
>            - const: rockchip,rk3568v3-canfd
>            - const: rockchip,rk3568v2-canfd
>
> And submit that as v2.

That works for me. I will prepare a v2 with:

- the binding schema changed to use enum as suggested by Krzysztof
- RKCANFD_QUIRK_RK3568_ERRATUM_6 enabled for RK3588v2
- your Haikou patch added to the series

> But if it actually works, then personally I'm more than fine with
> enabling CAN-FD :-D .
>
> I guess Marc might have more insight where the FD issue triggered on
> the RK3568.

I will also double-check that CAN-FD still works with the v2 changes and
wait for Marc's feedback on the CAN-FD issue before deciding whether
RKCANFD_QUIRK_CANFD_BROKEN should stay disabled for RK3588v2.

Thanks,
Cunhao Lu