[PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays
Uwe Kleine-König (The Capable Hub)
u.kleine-koenig at baylibre.com
Mon Jul 6 00:19:47 PDT 2026
Hello Chen,
On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote:
> On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote:
> > - Use a single space in a of_device_id array terminator; A single space
> > after the opening { and before the closing } in non-empty
> > initializers;
> > - No comma after an array terminator;
> > - Also no trailing comma after a named initializer iff the
> iff -> if
This is actually intended. iff = "if and only if", see e.g.
https://en.wikipedia.org/wiki/If_and_only_if .
> > closing } is on the same line;
> >
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig at baylibre.com>
>
> [......]
>
> > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-sg2042.c
> > index 7d07b0ca7d29..0b6461172e6a 100644
> > --- a/drivers/pwm/pwm-sophgo-sg2042.c
> > +++ b/drivers/pwm/pwm-sophgo-sg2042.c
> > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_data = {
> > static const struct of_device_id sg2042_pwm_ids[] = {
> > {
> > .compatible = "sophgo,sg2042-pwm",
> > - .data = &sg2042_chip_data
> > - },
> > - {
> > + .data = &sg2042_chip_data,
> > + }, {
> > .compatible = "sophgo,sg2044-pwm",
> > - .data = &sg2044_chip_data
> > + .data = &sg2044_chip_data,
> > },
> > { }
> > };
>
> Changes to sophgo related files:
>
> Reviewed-by: Chen Wang <chen.wang at linux.dev>
Thanks
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20260706/84ae8ee7/attachment-0001.sig>
More information about the Linux-rockchip
mailing list