[PATCH] gpio/rockchip: Stop calling pinctrl for set_direction
Bartosz Golaszewski
bartosz.golaszewski at oss.qualcomm.com
Tue Jan 27 01:09:18 PST 2026
On Mon, 26 Jan 2026 12:12:26 +0000, Robin Murphy wrote:
> Marking the whole controller as sleeping due to the pinctrl calls in the
> .direction_{input,output} callbacks has the unfortunate side effect that
> legitimate invocations of .get and .set, which cannot themselves sleep,
> in atomic context now spew WARN()s from gpiolib.
>
> However, as Heiko points out, the driver doing this is a bit silly to
> begin with, as the pinctrl .gpio_set_direction hook doesn't even care
> about the direction, the hook is only used to claim the mux. And sure
> enough, the .gpio_request_enable hook exists to serve this very purpose,
> so switch to that and remove the problematic business entirely.
>
> [...]
Applied, thanks!
[1/1] gpio/rockchip: Stop calling pinctrl for set_direction
commit: 7ca497be00163610afb663867db24ac408752f13
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski at oss.qualcomm.com>
More information about the Linux-rockchip
mailing list