[PATCH] spi: rockchip: Use plain request_irq()

Mark Brown broonie at kernel.org
Mon Jan 19 08:25:12 PST 2026


On Sat, Jan 17, 2026 at 10:10:09AM +0800, Shawn Lin wrote:
> 在 2026/01/16 星期五 23:37, Mark Brown 写道:

> > TBH it looked to me more like there'd been some deferral of more complex
> > work at some point but that didn't make it into the final code.  In

> Ah, indeed,rockchip_spi_isr() directly performs R/W pio in hardirq
> context which doesn't seem advisable, so probably some better
> improvement is needed in the furture. Anyway, fix the warning right
> now as $subject patch looks sensible:

Generally the best pattern with this stuff is to do PIO in process
context - it looks like the driver already has a copybreak to use DMA
for larger transfers on systems that have DMA support so this should
only be happening for very short transfers in which case the context
thrashing from going to interrupt context is probably hurting
performance anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20260119/cedafc51/attachment.sig>


More information about the Linux-rockchip mailing list