[PATCH v3 4/4] ARM: dts: rockchip: Add Onion Omega4 Evaluation Board
Jonas Karlman
jonas at kwiboo.se
Sat Feb 14 02:17:52 PST 2026
Hi Fabio,
On 2/11/2026 12:03 PM, Fabio Estevam wrote:
> Hi Jonas,
>
> On Tue, Feb 10, 2026 at 1:53 PM Jonas Karlman <jonas at kwiboo.se> wrote:
>
>> nit: Is rv1103b needed in all three compatible strings? The last one is
>> already pointing out that this is the rv1103b soc, also the other Onion
>> Omega boards in-tree use onion,omega and onion,omega2+.
>
> All the boards inside arch/arm/boot/dts/rockchip/Makefile start with
> the SoC name, so I prefer to be consistent.
I do not follow, the .dts-filename typically do not fully follow the
topmost compatible for the board on Rockchip platform.
The typical convention for Rockchip platform is:
compatible: "<vendor>,<board model>[-<revision>]",
["<vendor>,<som model>",]
"rockchip,<soc>"
and the filename is typically:
board dts: <soc>-[<vendor>-]<board model>[-<revision>].dts
som dtsi: <soc>-[<vendor>-]<som model>.dtsi
soc dtsi: <soc>.dtsi
The board model typically only include <soc> if there are multiple
versions/revisions sharing same/similar model name.
And in mainline U-Boot we try to follow this convention for Rockchip
defconfig naming:
defconfig: [<vendor>-]<board model>-<soc>_defconfig
So my question remains, why do the soc (rv1103b) name need to be
repeated in all compatible parts? Is there expected to be another Onion
Omega4 version/revision using a different Rockchip SoC?
And if that is the case, then probably only the SOM part would need
the soc part, not the topmost part of the compatible.
Regards,
Jonas
> I have addressed all of the other feedback you gave me and sent a v4.
>
> Thanks
More information about the Linux-rockchip
mailing list