Re: [PATCH 1/2] arm64:?==?utf-8?q? dts: rockchip: Make eeprom read-only for Radxa ROCK 3C

[Dragan Simic]

Hello Naoki,

On Monday, November 10, 2025 04:54 CET, FUKAUMI Naoki <naoki at radxa.com> wrote:
> Make EEPROM read-only as it may contain factory-programmed
> board-specific data.
> 
> Fixes: ee219017ddb50 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
> index 6224d72813e59..f92f6374c6255 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
> @@ -466,6 +466,7 @@ eeprom: eeprom at 50 {
>  		compatible = "belling,bl24c16a", "atmel,24c16";
>  		reg = <0x50>;
>  		pagesize = <16>;
> +		read-only;
>  	};
>  };

I've checked the board schematic and making this BL24C16 chip
read-only makes sense to me.  However, I think that the patch
description should be expanded to contain a better description
of what might be found in the chip, such as a factory-programmed
MAC address.  Also, providing a link to the board schematic, as
a reference, would be a good idea.

With these remarks addressed in a v2, please feel free to include

Reviewed-by: Dragan Simic <dsimic at manjaro.org>