[GIT PULL] Rockchip clock changes for 6.15 #1
Stephen Boyd
sboyd at kernel.org
Wed Mar 12 16:16:59 PDT 2025
Quoting Heiko Stuebner (2025-03-11 23:03:00)
> Am Dienstag, 11. März 2025, 19:05:50 MEZ schrieb Stephen Boyd:
> >
> > Did you see this warning?
> >
> > drivers/clk/rockchip/rst-rk3562.c:21:57: error: initialized field overwritten [-Werror=override-init]
> > 21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] = (0x20000*4 + reg * 16 + bit)
> > | ^
> > drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'RK3562_DDRCRU_RESET_OFFSET'
> > 266 | RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8),
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/clk/rockchip/rst-rk3562.c:21:57: note: (near initialization for 'rk3562_register_offset[173]')
> > 21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] = (0x20000*4 + reg * 16 + bit)
> > | ^
> > drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'RK3562_DDRCRU_RESET_OFFSET'
> > 266 | RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8),
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
>
>
> interestingly, this did not turn up in my build test.
> But that splat is really helpful too, because it made it easy to see
> that one of the ids is doubled in the dt-binding header.
>
> include/dt-bindings/reset/rockchip,rk3562-cru.h:
>
> #define SRST_P_DDR_HWLP 173
> #define SRST_P_DDR_PHY 173
>
>
> I'll fix up the double id.
Thanks.
>
>
> Out of curiosity, what toolchain was that?
>
$ ~/compilers/gcc-12.2.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version
aarch64-linux-gcc (GCC) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
More information about the Linux-rockchip
mailing list