[PATCH] USB: OHCI/UHCI: Add soft dependencies on ehci_hcd
Alan Stern
stern at rowland.harvard.edu
Wed Dec 31 07:20:56 PST 2025
On Wed, Dec 31, 2025 at 05:38:05PM +0800, Huacai Chen wrote:
> From your long explanation I think the order is still important. "New
> connection" may be harmless for USB keyboard/mouse, but really
> unacceptable for USB storage.
>
> If we revert 05c92da0c524 and 9beeee6584b9, the real problem doesn't
> disappear. Then we go back to pre-2008 to rely on distributions
> providing a correct modprobe.conf?
The warning message in 9beeee6584b9 was written a long time ago; back
then I didn't realize that the real dependency was between the -pci
drivers rather than the -hcd ones (and I wasn't aware of softdeps). The
soft dependency in 05c92da0c524 is between the -pci drivers, so it is
correct.
To put it another way, on PCI-based systems it is not a problem if the
modules are loaded in this order: uhci-hcd, ohci-hcd, ehci-hcd,
ehci-pci, ohci-pci, uhci-pci. Even though the warning message would be
logged, the message would be wrong.
On the whole, I think the best approach is to revert 9beeee6584b9's
warning message while keeping 05c92da0c524's softdeps. Greg might not
approve of soft dependencies between modules in general, but in this
case I believe it is appropriate.
And so your patch really is not needed, as far as I can tell. While it
might in theory help some peculiar platform-dependent scenario, I'm
not aware of any platforms like that.
Alan Stern
More information about the Linux-rockchip
mailing list