[PATCH DO-NOT-MERGE 1/4] media: rkvdec: minor fixes for current DETLEV patches
Christian Hewitt
christianshewitt at gmail.com
Sat Dec 6 00:28:06 PST 2025
RK3588 TRM Part 1 para 5.5.9 shows RKVDEC_SWREG12_SENCODARY_EN as
the register name so the 'secondary' typo looks maybe intentional,
but using correct spellings improves code readability.
RK3588 TRM Part 1 para 5.4.3 shows RKVDEC_1080P_PIXELS should use
1920x1088 (to be 4px aligned) not 1920x1080.
Also correct some H264 references in the H265 driver.
Signed-off-by: Christian Hewitt <christianshewitt at gmail.com>
---
.../media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h | 4 ++--
.../media/platform/rockchip/rkvdec/rkvdec-vdpu383-hevc.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h
index 11b545e9ee7e..7cc6cbb8e549 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h
@@ -24,7 +24,7 @@
#define MAX_SLICE_NUMBER 0x3fff
-#define RKVDEC_1080P_PIXELS (1920 * 1080)
+#define RKVDEC_1080P_PIXELS (1920 * 1088)
#define RKVDEC_4K_PIXELS (4096 * 2304)
#define RKVDEC_8K_PIXELS (7680 * 4320)
#define RKVDEC_TIMEOUT_1080p (0xefffff)
@@ -90,7 +90,7 @@ struct rkvdec_vdpu381_regs_common {
u32 reserved4 : 7;
} reg011;
- struct rkvdec_vdpu381_sencodary_en {
+ struct rkvdec_vdpu381_secondary_en {
u32 wr_ddr_align_en : 1;
u32 colmv_compress_en : 1;
u32 fbc_e : 1;
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-hevc.c b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-hevc.c
index dd7481a4353d..b4fc0d423c16 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-hevc.c
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-hevc.c
@@ -275,11 +275,11 @@ static void set_pps_ref_pic_poc(struct rkvdec_hevc_sps_pps *hw_ps, u32 poc, int
static void assemble_hw_pps(struct rkvdec_ctx *ctx,
struct rkvdec_hevc_run *run)
{
- struct rkvdec_hevc_ctx *h264_ctx = ctx->priv;
+ struct rkvdec_hevc_ctx *h265_ctx = ctx->priv;
const struct v4l2_ctrl_hevc_sps *sps = run->sps;
const struct v4l2_ctrl_hevc_pps *pps = run->pps;
const struct v4l2_ctrl_hevc_decode_params *dec_params = run->decode_params;
- struct rkvdec_hevc_priv_tbl *priv_tbl = h264_ctx->priv_tbl.cpu;
+ struct rkvdec_hevc_priv_tbl *priv_tbl = h265_ctx->priv_tbl.cpu;
struct rkvdec_hevc_sps_pps *hw_ps;
bool tiles_enabled;
s32 max_cu_width;
@@ -479,7 +479,7 @@ static void config_registers(struct rkvdec_ctx *ctx,
memset(regs, 0, sizeof(*regs));
- /* Set H264 mode */
+ /* Set HEVC mode */
regs->common.reg008_dec_mode = VDPU383_MODE_HEVC;
/* Set input stream length */
--
2.34.1
More information about the Linux-rockchip
mailing list