[PATCH] drivers: pci: controller: pcie-rockchip: Use dev_err_probe()

Krzysztof Kozlowski krzk at kernel.org
Thu Apr 3 23:09:40 PDT 2025


On 03/04/2025 09:43, shao.mingyin at zte.com.cn wrote:
> From: Zhang Enpei <zhang.enpei at zte.com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Zhang Enpei <zhang.enpei at zte.com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin at zte.com.cn>
> ---
Considering zte is sending untested patches from poor automation (or AI
generated), this might be correct or might not be because it does not
look like probe path.

Anyway, don't send patch by patch and line by line. Why you did not
decide to fix all of the places in these drivers?

NAK

Best regards,
Krzysztof



More information about the Linux-rockchip mailing list