[PATCH v8 2/8] i2c: muxes: add support for tsd,mule-i2c multiplexer

Christophe JAILLET christophe.jaillet at wanadoo.fr
Sat Sep 28 09:56:40 PDT 2024


Le 06/09/2024 à 17:54, Farouk Bouabid a écrit :
> Theobroma Systems Mule is an MCU that emulates a set of I2C devices,
> among which an amc6821 and devices that are reachable through an I2C-mux.
> The devices on the mux can be selected by writing the appropriate device
> number to an I2C config register (amc6821 reg 0xff).
> 
> This driver is expected to be probed as a platform device with amc6821
> as its parent i2c device.
> 
> Add support for the mule-i2c-mux platform driver. The amc6821 driver
> support for the mux will be added in a later commit.
> 
> Reviewed-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
> Signed-off-by: Farouk Bouabid <farouk.bouabid at cherry.de>
> ---

Hi,

> +static const struct of_device_id mule_i2c_mux_of_match[] = {
> +	{ .compatible = "tsd,mule-i2c-mux", },
> +	{},

Nitpick (in case of v9): usually, a comma is not added after a terminator.

> +};

...



More information about the Linux-rockchip mailing list