[PATCH v2 0/5] Add dev_warn_probe() and improve error handling in Rockchip SPI drivers
Dragan Simic
dsimic at manjaro.org
Fri Sep 27 21:12:44 PDT 2024
This is a small series that introduces dev_warn_probe() function, which
produces warnings on failed resource acquisitions, and improves error
handling in the probe paths of Rockchip SPI drivers, by using functions
dev_err_probe() and dev_warn_probe() properly in multiple places.
This series also performs a bunch of small, rather trivial code cleanups,
to make the code neater and a bit easier to read.
Changes in v2:
- Collected three Reviewed-by tags from Heiko [1][2][3]
- Dropped patch 3/5, [4] as suggested by Mark, [5] improved the check
to use dev_err_probe() and folded that into new patch 5/5
- Added new patch 4/5 that introduces function dev_warn_probe() that
produces warnings in probe paths, to avoid the promotion of logged
messages from warnings to errors, as noted by Heiko [6]
- Adjusted the description of the series and of the individual patches
a bit to reflect the changes, where appropriate
Link to v1: https://lore.kernel.org/linux-rockchip/cover.1727337732.git.dsimic@manjaro.org/T/#u
[1] https://lore.kernel.org/linux-rockchip/6085918.31tnzDBltd@phil/
[2] https://lore.kernel.org/linux-rockchip/2285557.3ZeAukHxDK@phil/
[3] https://lore.kernel.org/linux-rockchip/10409403.0AQdONaE2F@phil/
[4] https://lore.kernel.org/linux-rockchip/ce2e7f90e62b15adc2bed1f53122ad39c3a9b5ac.1727337732.git.dsimic@manjaro.org/
[5] https://lore.kernel.org/linux-rockchip/ZvUmk48R4hZYlO71@finisterre.sirena.org.uk/
[6] https://lore.kernel.org/linux-rockchip/6673004.tM3a2QDmDi@phil/
Dragan Simic (5):
spi: rockchip: Perform trivial code cleanups
spi: rockchip-sfc: Perform trivial code cleanups
spi: rockchip-sfc: Use dev_err_probe() in the probe path
driver core: Add device probe log helper dev_warn_probe()
spi: rockchip: Use dev_{err,warn}_probe() in the probe path
drivers/base/core.c | 110 +++++++++++++++++++++++++--------
drivers/spi/spi-rockchip-sfc.c | 21 +++----
drivers/spi/spi-rockchip.c | 55 ++++++++---------
include/linux/dev_printk.h | 1 +
4 files changed, 117 insertions(+), 70 deletions(-)
More information about the Linux-rockchip
mailing list