[PATCH] drm/rockchip: include rockchip_drm_drv.h

Andy Yan andyshrk at 163.com
Thu Sep 5 17:42:41 PDT 2024


Hi  Min Hua,
   Thanks for your work

At 2024-09-06 06:38:50, "Min-Hua Chen" <minhuadotchen at gmail.com> wrote:
>Include rockchip_drm_drv.h to fix the follow sparse warning:
>
>drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse:
>warning: symbol 'vop2_platform_driver' was not declared.
>Should it be static?
>
>No functional change intended.
>
>Signed-off-by: Min-Hua Chen <minhuadotchen at gmail.com>
>---
> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>index 18efb3fe1c00..c678d1b0fd7c 100644
>--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>@@ -14,6 +14,7 @@
> #include <drm/drm_print.h>
> 
> #include "rockchip_drm_vop2.h"
>+#include "rockchip_drm_drv.h"
> 

We already have a patch[0] include rockchip_drm_drv.h in rockchip_drm_vop2.h

[0]https://patchwork.kernel.org/project/linux-rockchip/patch/20240904120238.3856782-3-andyshrk@163.com/ 

> static const uint32_t formats_cluster[] = {
> 	DRM_FORMAT_XRGB2101010,
>-- 
>2.43.0
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip at lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip


More information about the Linux-rockchip mailing list