[PATCH] soc: Switch back to struct platform_driver::remove()

Andrew Jeffery andrew at codeconstruct.com.au
Tue Oct 29 17:23:09 PDT 2024


On Tue, 2024-10-29 at 08:48 +0100, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement
> for
> platform drivers.
> 
> Convert all platform drivers below drivers/soc to use .remove(), with
> the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is
> done
> by just changing the structure member name in the driver initializer.
> 
> On the way do a few whitespace changes to make indention consistent.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at baylibre.com>
> ---
> Hello,
> 
> I did a single patch for all of drivers/soc. While I usually prefer
> to
> do one logical change per patch, this seems to be overengineering
> here
> as the individual changes are really trivial and shouldn't be much in
> the way for stable backports.
> 
> There is no dedicated maintainer for all of drivers/soc, but I'd
> expect
> it to be ok to be picked up by the arm soc team.
> 
> This is based on today's next, if conflicts arise when you apply it
> at
> some later time and don't want to resolve them, feel free to just
> drop
> the changes to the conflicting files. I'll notice and followup at a
> later time then. Or ask me for a fixed resend.
> 
> Best regards
> Uwe
> 
>  drivers/soc/aspeed/aspeed-lpc-ctrl.c        | 2 +-
>  drivers/soc/aspeed/aspeed-lpc-snoop.c       | 2 +-
>  drivers/soc/aspeed/aspeed-p2a-ctrl.c        | 2 +-
>  drivers/soc/aspeed/aspeed-uart-routing.c    | 2 +-

Acked-by: Andrew Jeffery <andrew at codeconstruct.com.au> # aspeed



More information about the Linux-rockchip mailing list