[PATCH v6] rockchip/drm: vop2: add support for gamma LUT

[Piotr Zalewski]

Hi again

On Monday, October 28th, 2024 at 5:40 PM, Piotr Zalewski <pZ010001011111 at proton.me> wrote:

> On Monday, October 28th, 2024 at 7:42 AM, Andy Yan andyshrk at 163.com wrote:
> 
> > Hi Piotr，
> 
> 
> Hi Andy
> 
> > Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a buildroot + weston environment:
> > weston --backend=drm-backend.so -i 0 --continue-without-input
> > weston-simple-egl
> 
> 
> Thank you for testing it!
> 
> > simple-egl will draw a triangle on the desktop.
> > After the patch applied，the triangle will flicker again and agian。
> > So it break some function。
> 
> 
> Did you have gamma on? The screen flickered for me when I ran something
> writing gamma LUT frequently because of disable step I reckon.
> 
> > I've been quite busy lately, and it will take some time before I can analyze what the specific reason is.
> 
> 
> Np, I will try to reproduce this behavior with weston on Pinetab2 in the
> meantime.
>

So I got weston (version 13) and ran it as you did, then ran the same
client. Nothing flickered. Since weston doesn't support gamma control, I
ran sway in the other tty and set color temperature there with `gammastep
-O 3000`. Then switched again to weston and color temp. wasn't retained,
triangle didn't flicker. Then I ran weston-simple-egl under sway (while
having `gammastep` running and doing gamma lut adjustments every ~5
seconds) and the triangle didn't flicker too (but there were _expected_
flickers every ~5 seconds because of gamma adjustments by gammastep).

Best Regards, Piotr Zalewski