[PATCH 09/15] arm64: dts: rockchip: add lower USB3 port to opi5max

[Jimmy Hon]

On Sat, Oct 26, 2024 at 5:03 AM Jimmy Hon <honyuenkwun at gmail.com> wrote:
>
> Enable full support (XHCI) for the lower USB3 port from Orange Pi 5 Max.
>v0
> the vcc5v0_usb30 regulator shares the same enable gpio pin as the
> vcc5v0_usb20 regulator.


> --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-max.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-max.dts
> @@ -111,6 +111,8 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>         };
>
>         /* Represents the vcc5v0_usb20 in the schematic */
> +       /* Also represents the vcc5v0_usb30 in the schematic,
> +          both regulators share the same enable gpio */
>         vcc5v0_host: vcc5v0-host-regulator {
>                 compatible = "regulator-fixed";
>                 enable-active-high;

Is there a better way to represent the two USB host regulators? In the
schematic [1] page 14, there's two regulators vcc5v0_usb20 and
vcc5v0_usb30, however they both use USB_HOST_PWREN as the EN pin.

In the case of the OPI5Plus [2] page 16, it uses a different EN pin
for vcc5v0_usb30. However, in the mainline OPI5Plus, it left
vcc5v0_usb30 regulator out of the dts [3].

[1] http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/service-and-support/Orange-Pi-5-Max.html
[2] http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/service-and-support/Orange-Pi-5-plus.html
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts#n209

Jimmy