[PATCH 05/15] arm64: dts: rockchip: add PCIe network controller to opi5max

Jimmy Hon honyuenkwun at gmail.com
Sat Oct 26 13:29:11 PDT 2024


On Sat, Oct 26, 2024 at 5:03 AM Jimmy Hon <honyuenkwun at gmail.com> wrote:
>
> +       /* pcie eth. not a real regulator. 33VAUX */
> +       vcc_3v3_aux: vcc-3v3-aux-regulator {
> +               compatible = "regulator-fixed";
> +               /* Ethernet_power_en */
> +               gpios = <&gpio0 RK_PD3 GPIO_ACTIVE_LOW>;
> +               regulator-name = "33vaux";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +               startup-delay-us = <50000>;
> +               vin-supply = <&vcc_3v3_s3>;
> +       };
> +
What's the best way to treat this? In the schematic [1] page 21, it
doesn't look like a normal regulator with IN, VOUT, and EN pins.

At least the OPI5Max schematic mentions how the 33VAUX and
Ethernet_power_en pin are connected.
The OPI5Plus schematic doesn't mention where the Ethernet_power_en pin
goes. However, it's modeled in the mainline DTS as a regulator. [2]

Regarding the name, I can't have the node id called "33vaux", so
what's the alternative. Should I use vcc3v3_pcie_eth like the
OPI5Plus?

[1] http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/service-and-support/Orange-Pi-5-Max.html
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts#n179

Jimmy



More information about the Linux-rockchip mailing list