[PATCH v5 4/4] gpio: rockchip: Set input direction when request irq
Ye Zhang
ye.zhang at rock-chips.com
Mon Nov 11 17:54:08 PST 2024
Since the GPIO can only generate interrupts when its direction is set to
input, it is set to input before requesting the interrupt resources.
Signed-off-by: Ye Zhang <ye.zhang at rock-chips.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.com>
---
drivers/gpio/gpio-rockchip.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index c090cac694bf..cdfdd5501a1e 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -476,8 +476,11 @@ static int rockchip_irq_reqres(struct irq_data *d)
{
struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
struct rockchip_pin_bank *bank = gc->private;
+ irq_hw_number_t hwirq = irqd_to_hwirq(d);
- return gpiochip_reqres_irq(&bank->gpio_chip, d->hwirq);
+ rockchip_gpio_direction_input(&bank->gpio_chip, hwirq);
+
+ return gpiochip_reqres_irq(&bank->gpio_chip, hwirq);
}
static void rockchip_irq_relres(struct irq_data *d)
--
2.34.1
More information about the Linux-rockchip
mailing list