[PATCH 2/5] dt-bindings: mfd: rk809: Add missing audio codec properties
Jonas Karlman
jonas at kwiboo.se
Wed Jun 19 05:20:12 PDT 2024
Hi Cristian,
On 2024-06-19 13:23, Cristian Ciocaltea wrote:
> The RK809 MFD provides a RK817 compatible audio codec, supported by the
> rk817_codec driver.
>
> This has been already in use by several boards: rk3566-quartz64-b,
> k3566-roc-pc, rk3568-evb1-v10, rk3568-lubancat-2, rk3568-odroid-m1,
> rk3568-rock-3a. However, dtbs_check fails for all of them:
>
> DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb
> rk3568-rock-3a.dtb: pmic at 20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#
>
> Document the missing audio codec properties as found on the
> rockchip,rk817 schema.
This is duplicate of "dt-bindings: mfd: rk809: Add audio codec properties"
part of "arm64: dts: rockchip: Add Radxa ROCK 3B" series.
https://lore.kernel.org/all/20240505134120.2828885-3-jonas@kwiboo.se/
A v2 of that series with fixes for reported issues is imminent.
How do you want me to preceded with such v2 series?
Regards,
Jonas
>
> Fixes: 6c38ca03406e ("dt-bindings: mfd: rk808: Convert bindings to yaml")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea at collabora.com>
> ---
> .../devicetree/bindings/mfd/rockchip,rk809.yaml | 30 +++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> index a327d73f3c43..cadfb5f1c631 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> description: |
> Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD
> - that includes regulators, an RTC, and power button.
> + that includes regulators, an RTC, a power button and an audio codec.
>
> properties:
> compatible:
> @@ -93,6 +93,34 @@ properties:
> unevaluatedProperties: false
> unevaluatedProperties: false
>
> + clocks:
> + description:
> + The input clock for the audio codec.
> +
> + clock-names:
> + description:
> + The clock name for the codec clock.
> + items:
> + - const: mclk
> +
> + '#sound-dai-cells':
> + description:
> + Needed for the interpretation of sound dais.
> + const: 0
> +
> + codec:
> + description: |
> + The child node for the codec to hold additional properties. If no
> + additional properties are required for the codec, this node can be
> + omitted.
> + type: object
> + additionalProperties: false
> + properties:
> + rockchip,mic-in-differential:
> + type: boolean
> + description:
> + Describes if the microphone uses differential mode.
> +
> allOf:
> - if:
> properties:
>
More information about the Linux-rockchip
mailing list