[PATCH V2 0/3] Add GameForce Ace

[Heiko Stübner]

Am Freitag, 30. August 2024, 18:33:50 CEST schrieb Rob Herring (Arm):
> 
> On Thu, 29 Aug 2024 15:45:14 -0500, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan at hotmail.com>
> > 
> > Add support for the GameForce Ace. The GameForce Ace is an RK3588s
> > based gaming device with a 1080p display, touchscreen, hall effect
> > joysticks and triggers, 128GB of eMMC, 8GB or 12GB of RAM, WiFi 5,
> > and support for a 2242 NVME.
> > 
> > Changes since V1:
> >  - Update eMMC changes to note proper authorship.
> >  - Removed cw2015 changes for dual cell configuration. For the moment
> >    it's just cosmetic (aside from voltage_now reading incorrectly, no
> >    other issues were observed).
> >  - Removed USB bindings because vbus regulator isn't ready yet.
> > 
> > Alex Zhao (1):
> >   arm64: dts: rockchip: rk3588s fix sdio pins to pull up
> > 
> > Chris Morgan (2):
> >   dt-bindings: arm: rockchip: Add GameForce Ace
> >   arm64: dts: rockchip: Add GameForce Ace
> > 
> >  .../devicetree/bindings/arm/rockchip.yaml     |    5 +
> >  arch/arm64/boot/dts/rockchip/Makefile         |    1 +
> >  .../dts/rockchip/rk3588-base-pinctrl.dtsi     |   10 +-
> >  .../dts/rockchip/rk3588s-gameforce-ace.dts    | 1237 +++++++++++++++++
> >  4 files changed, 1248 insertions(+), 5 deletions(-)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts
> > 
> > --
> > 2.34.1
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-gameforce-ace.dtb' for 20240829204517.398669-1-macroalpha82 at gmail.com:
> 
> arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: video-codec at fdb50000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu'] is too long
> 	'rockchip,rk3588-vpu121' is not one of ['rockchip,rk3036-vpu', 'rockchip,rk3066-vpu', 'rockchip,rk3288-vpu', 'rockchip,rk3328-vpu', 'rockchip,rk3399-vpu', 'rockchip,px30-vpu', 'rockchip,rk3568-vpu', 'rockchip,rk3588-av1-vpu']
> 	'rockchip,rk3188-vpu' was expected
> 	'rockchip,rk3228-vpu' was expected
> 	'rockchip,rk3066-vpu' was expected
> 	'rockchip,rk3399-vpu' was expected
> 	from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml#
> arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec at fdb50000: failed to match any schema with compatible: ['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu']
> arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec at fdba0000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
> arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec at fdba4000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
> arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec at fdba8000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
> arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec at fdbac000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']

That is not Chris' fault ;-) .
The relevant vpu binding patches have made it to the media-tree [0], but
not linux-next yet it seems.

So this should sort itself shortly I hope.

[0]
https://git.linuxtv.org/media_stage.git/commit/?id=1e490a1ea64396b98db8c233360093e264b0c10b
for ['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu']

https://git.linuxtv.org/media_stage.git/commit/?id=b92346d2dba0048bfce7114225250bef73f83ad2
for ['rockchip,rk3588-vepu121']