[PATCH v4 3/4] mmc: dw_mmc-rockchip: Skip all phases bigger than 270 degrees
Detlev Casanova
detlev.casanova at collabora.com
Thu Aug 22 14:15:33 PDT 2024
From: Shawn Lin <shawn.lin at rock-chips.com>
Per design recommendation, it'd better not try to use any phase
which is bigger than 270. Let's officially follow this.
Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
(cherry picked from commit 2a53aab5cfa43065b2e979959d727332a8a03c03)
Signed-off-by: Detlev Casanova <detlev.casanova at collabora.com>
---
drivers/mmc/host/dw_mmc-rockchip.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index 2748f9bf2691..1458cb5fd5c7 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -310,6 +310,9 @@ static int dw_mci_rk3288_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
/* Try each phase and extract good ranges */
for (i = 0; i < priv->num_phases; ) {
+ /* Cannot guarantee any phases larger than 270 would work well */
+ if (TUNING_ITERATION_TO_PHASE(i, priv->num_phases) > 270)
+ break;
rockchip_mmc_set_phase(host, true,
TUNING_ITERATION_TO_PHASE(
i,
--
2.46.0
More information about the Linux-rockchip
mailing list