[PATCH v3 3/3] arm64: dts: rockchip: improve eMMC speed on NanoPi R2S Plus

[Sergey 'Jin' Bostandzhyan]

Hi,

On Fri, Aug 16, 2024 at 08:51:40AM +0200, Dragan Simic wrote:
> On 2024-08-14 19:00, Sergey Bostandzhyan wrote:
> >This change has been suggested by Daniel Golle during patch review,
> >adding mmc-hs200-1_8v; makes sure that eMMC gets detected as HS200
> >which improves it's performance.
> 
> Describing who suggested the patch in the patch description looks
> out of place.  Instead, you should add a Suggested-by tag, whose
> purpose is exactly to describe who suggested the patch.

thank you for the pointer, I guess I missed that, I generally had a hard time to 
come to grips with the hole process as there are so many details and nuances.

Heiko, I guess it is too late to fix that now, sine you wrote that the
patch has been applied?

Kind regards,
Sergey



> >---
> > arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> >b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> >index 12eabdbf8fe8..146b1da198b8 100644
> >--- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> >+++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> >@@ -23,6 +23,7 @@
> > 	cap-mmc-highspeed;
> > 	supports-emmc;
> > 	disable-wp;
> >+	mmc-hs200-1_8v;
> > 	non-removable;
> > 	num-slots = <1>;
> > 	pinctrl-names = "default";