[PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller
Shawn Lin
shawn.lin at rock-chips.com
Thu Aug 8 17:33:56 PDT 2024
Hi Krzysztof
在 2024/8/8 18:34, Krzysztof Kozlowski 写道:
> On 08/08/2024 05:52, Shawn Lin wrote:
>> Document Rockchip UFS host controller for RK3576 SoC.
>>
>> Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
>>
>> ---
>>
>> Changes in v2:
>> - renmae file name
>> - fix all errors and pass the dt_binding_check:
>> make dt_binding_check DT_SCHEMA_FILES=rockchip,rk3576-ufs.yaml
>
>
> You did much more. Some properties appeared which were here not
> before... The way you send patches makes it difficult to review. Look:
>
Yes, will update full changelog next version.
> b4 diff '<1723089163-28983-3-git-send-email-shawn.lin at rock-chips.com>'
> Grabbing thread from
> lore.kernel.org/all/1723089163-28983-3-git-send-email-shawn.lin at rock-chips.com/t.mbox.gz
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> Added from v1: 4 patches
> ---
> Analyzing 18 messages in the thread
> WARNING: duplicate messages found at index 2
> Subject 1: dt-bindings: ufs: Document Rockchip UFS host controller
> Subject 2: dt-bindings: ufs: Document Rockchip UFS host controller
> 2 is not a reply... assume additional patch
> Looking for additional code-review trailers on lore.kernel.org
> Analyzing 0 code-review messages
> Preparing fake-am for v1: Init support for RK3576 UFS controller
> range: e86f0d80765d..3ae8e722f6ab
> Preparing fake-am for v2: scsi: ufs: core: Export
> ufshcd_dme_link_startup() helper
> ERROR: v2 series incomplete; unable to create a fake-am range
> ---
> Could not create fake-am range for upper series v2
>
>
> So how can we handle it? Your job is to use standard process so life of
> reviewers is not more difficult than it should be.
>
> Provide FULL CHANGELOG with explanation what happened here.
Sorry for that. I'll improve them when the dependency is solved.
>
> Best regards,
> Krzysztof
>
More information about the Linux-rockchip
mailing list