[RESEND PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller

Krzysztof Kozlowski krzk at kernel.org
Thu Aug 8 03:30:12 PDT 2024


On 08/08/2024 11:30, Rob Herring (Arm) wrote:
> 
> On Thu, 08 Aug 2024 12:27:00 +0800, Shawn Lin wrote:
>> Document Rockchip UFS host controller for RK3576 SoC.
>>
>> Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
>>
>> ---
>>
>> Changes in v2:
>> - renmae file name
>> - fix all errors and pass the dt_binding_check:
>>   make dt_binding_check DT_SCHEMA_FILES=rockchip,rk3576-ufs.yaml
>>
>>  .../bindings/ufs/rockchip,rk3576-ufs.yaml          | 96 ++++++++++++++++++++++
>>  1 file changed, 96 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.yaml
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.example.dts:24:18: fatal error: dt-bindings/clock/rockchip,rk3576-cru.h: No such file or directory
>    24 |         #include <dt-bindings/clock/rockchip,rk3576-cru.h>
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.

Nothing improved... stop sending new versions so fast but allow people
to respond to your patches and then implement the feedback.

Best regards,
Krzysztof




More information about the Linux-rockchip mailing list