[RFC 1/2] dt-bindings: arm: rockchip: add Radxa E52C

[Dragan Simic]

On 2024-08-07 20:10, Dragan Simic wrote:
> On 2024-08-07 19:59, FUKAUMI Naoki wrote:
>> On 8/7/24 23:50, Dragan Simic wrote:
>>> On 2024-08-07 10:46, FUKAUMI Naoki wrote:
>>>> Add devicetree binding for the Radxa E52C.
>>>> 
>>>> Radxa E52C is a compact network computer using the Rockchip RK3582
>>>> chip.
>>>> 
>>>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
>>>> ---
>>>> how should we handle RK3582? as far as I know, it's just an another
>>>> version of RK3588S.
>>> 
>>> Could you, please, provide links to downstream kernel code from
>>> Rockchip that shows the CPU and GPU OPPs for the RK3582?
>> 
>> https://github.com/radxa/kernel/commits/linux-6.1-stan-rkr1/
> 
> In fact, we'd need downstream source code from Rockchip as a reference,
> instead of downstream source code from Radxa.
> 
> The link avaliable below seems to provide the required downstream
> information about the RK3582, straight from Rockchip.  I'll go through
> it and come back with an update.
> 
> https://raw.githubusercontent.com/rockchip-linux/kernel/develop-5.10/arch/arm64/boot/dts/rockchip/rk3528.dtsi

Oops, my bad, somehow I got RK3582 and RK3528 mixed up, sorry for that.
There have been quite a few similar yet different SoCs from Rockchip
recently, so mixing them up has become rather easy. :)

AFAICT, there's no information about the RK3582 available from the 
Rockchip
downstream kernel code in the GitHub repository linked above, so we'll 
have
to wait for that to also become publicly available from Rockchip.

>> I noticed there are some differences between source and schematic. I
>> guess there are some copy & paste work, both are not so reliable...
>> 
>>> By the way, is the schematic of Radxa E52C available?
>> 
>> it's not yet available in public. everything, include hardware, is 
>> WIP.
>> but it will be available before end of this month.
> 
> I see, thanks for the clarification.  Then it's the best to wait until
> the actual public release of this new board.
> 
>>>> ---
>>>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>> 
>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> index 2ad835f4068e..ba6d03b37bef 100644
>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> @@ -759,6 +759,12 @@ properties:
>>>>            - const: radxa,cm3i
>>>>            - const: rockchip,rk3568
>>>> 
>>>> +      - description: Radxa E52C
>>>> +        items:
>>>> +          - enum:
>>>> +              - radxa,e52c
>>>> +          - const: rockchip,rk3588s
>>>> +
>>>>        - description: Radxa Rock
>>>>          items:
>>>>            - const: radxa,rock