[PATCH 00/15] PCI: Convert to platform remove callback returning void
Pali Rohár
pali at kernel.org
Mon Jun 12 11:17:26 PDT 2023
On Monday 12 June 2023 11:19:27 Bjorn Helgaas wrote:
> On Sun, Jun 11, 2023 at 03:24:23PM +0200, Pali Rohár wrote:
> > On Friday 02 June 2023 16:37:34 Bjorn Helgaas wrote:
> > > On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-König wrote:
> > > > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-König wrote:
> > > > > this series adapts the platform drivers below drivers/pci to
> > > > > use the .remove_new() callback. Compared to the traditional
> > > > > .remove() callback .remove_new() returns no value. This is a
> > > > > good thing because the driver core doesn't (and cannot) cope
> > > > > for errors during remove. The only effect of a non-zero return
> > > > > value in .remove() is that the driver core emits a warning.
> > > > > The device is removed anyhow and an early return from
> > > > > .remove() usually yields a resource leak.
> > ...
>
> > Hello Bjorn, it should be expected that other changes for PCIe drivers
> > sent by other people which were sent to the list before this patch
> > series and are still waiting for the review (because are without
> > comments), would be processed before and patches sent later.
>
> I don't think it's necessary to delay simple, easily-reviewed changes
> behind more complicated ones.
>
> > Also I would like to point out that in past I have sent fixes for PCIe
> > mvebu driver, which is currently in the broken state. And this is also
> > on waiting on the list.
>
> Thanks for this reminder. Would you mind reposting them? I poked
> around in patchwork and I must be doing something wrong because I
> can't find *any* patches from you, though obviously there are many.
>
> If you repost them at least we'll know unambiguously what is on the
> table.
>
> Bjorn
Well, my patches I reposted more times. And some were also reposted by
other people. I do not know if they are in patchwork, but they are in
email archive. For example last repost of aardvark patches are here:
https://lore.kernel.org/linux-pci/20220927141926.8895-1-kabel@kernel.org/
And some other aardvark are also here:
https://lore.kernel.org/linux-pci/20220711120626.11492-1-pali@kernel.org/
More information about the Linux-rockchip
mailing list