[PATCH v3 3/3] mtd: rawnand: rockchip-nand-controller: add skipbbt option

Richard Weinberger richard at nod.at
Thu Jul 13 08:17:15 PDT 2023


----- Ursprüngliche Mail -----
> 
>> > For the boot I think I proposed a DT property. I don't remember how far
>> > the discussion went.
>> 
>> Is there a web link of that discussion?
> 
> https://lore.kernel.org/linux-mtd/20230609104426.3901df54@xps-13/
> 
> Maybe the term "DT property" did not appear but that's what I had in
> mind :-) I don't know if it must be a chip or a partition property.
> 
> Richard, here is where I would like your feedback, I am kind of opposed
> to a "skip_bbt" module parameter. It's not a strong opinion, if you
> think it's fine I'm open.
> 
> I would rather prefer a DT property which says "do not use the
> standard pattern".

Yes, please no new module parameters. A module parameter should only affect
the behavior of the driver itself (e.g. debug mode) but not be device specific.
We made this mistake in the past too often. :-(
A single driver can serve more devices. Therefore IMHO controlling this via DT
makes perfectly sense.

Thanks,
//richard



More information about the Linux-rockchip mailing list