[PATCH 1/1] dt-bindings: power: rockchip: Increase pm_qos number
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Sat Oct 22 09:08:18 PDT 2022
On 21/10/2022 13:14, Sebastian Reichel wrote:
> On RK3588 some power domains require multiple qos blocks to be
> saved. The maximum required number for RK3588 is 8 (for VDPU).
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.com>
> ---
> .../devicetree/bindings/power/rockchip,power-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index 0d5e999a58f1..cf0f2946fea1 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -134,7 +134,7 @@ $defs:
> pm_qos:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> items:
> - maxItems: 1
> + maxItems: 8
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
You now require minItems 8. It's not what your commit msg is saying. You
miss here minItems: 1.
> description: |
> A number of phandles to qos blocks which need to be saved and restored
> while power domain switches state.
Best regards,
Krzysztof
More information about the Linux-rockchip
mailing list