[PATCH v7 11/24] dt-bindings: display: rockchip: dw-hdmi: Add additional clock
Robin Murphy
robin.murphy at arm.com
Wed Mar 9 04:06:59 PST 2022
On 2022-02-25 07:51, Sascha Hauer wrote:
> The rk3568 HDMI has an additional clock that needs to be enabled for the
> HDMI controller to work. The purpose of that clock is not clear. It is
> named "hclk" in the downstream driver, so use the same name.
Further to the clarification of the underlying purpose on the other
thread, I suggest we call the new clock "niu" and describe it as
something like "Additional clock required to ungate the bus interface on
certain SoCs".
Cheers,
Robin.
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> Acked-by: Rob Herring <robh at kernel.org>
> ---
>
> Notes:
> Changes since v4:
> - Add Robs Ack
>
> .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index 38ebb69830287..67a76f51637a7 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -44,12 +44,13 @@ properties:
> items:
> - {}
> - {}
> - # The next three clocks are all optional, but shall be specified in this
> + # The next four clocks are all optional, but shall be specified in this
> # order when present.
> - description: The HDMI CEC controller main clock
> - description: Power for GRF IO
> - description: External clock for some HDMI PHY (old clock name, deprecated)
> - description: External clock for some HDMI PHY (new name)
> + - description: hclk
>
> clock-names:
> minItems: 2
> @@ -61,13 +62,17 @@ properties:
> - grf
> - vpll
> - ref
> + - hclk
> - enum:
> - grf
> - vpll
> - ref
> + - hclk
> - enum:
> - vpll
> - ref
> + - hclk
> + - const: hclk
>
> ddc-i2c-bus:
> $ref: /schemas/types.yaml#/definitions/phandle
More information about the Linux-rockchip
mailing list