[PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs
Jarrah Gosbell
kernel at undef.tools
Sun Aug 14 15:01:52 PDT 2022
On 8/14/22 23:12, Peter Geis wrote:
>> ret = rga_parse_dt(rga);
>> - if (ret)
>> + if (ret) {
>> dev_err(&pdev->dev, "Unable to parse OF data\n");
> If this can return EPROBE_DEFER, shouldn't this be dev_err_probe
> instead of dev_err?
Looking into it that does make more sense. I suspect it wasn't done this
way originally because dev_err_probe isn't used elsewhere in rga.c. I'll
send a v2 with that change shortly.
Thanks for the review.
More information about the Linux-rockchip
mailing list